Random Values provider #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermyas
previously approved these changes
Jan 24, 2024
rzmahmood
reviewed
Jan 24, 2024
rzmahmood
reviewed
Jan 24, 2024
contracts/random/offchainsources/chainlink/ChainlinkSourceAdaptor.sol
Outdated
Show resolved
Hide resolved
rzmahmood
reviewed
Jan 24, 2024
rzmahmood
reviewed
Jan 24, 2024
rzmahmood
reviewed
Jan 24, 2024
rzmahmood
reviewed
Jan 24, 2024
… removes a slither issue related to using unitilised state variables.
…urn when requesting plus only allow fetching once
ermyas
reviewed
Feb 1, 2024
ermyas
reviewed
Feb 1, 2024
ermyas
reviewed
Feb 1, 2024
ermyas
reviewed
Feb 1, 2024
ermyas
previously approved these changes
Feb 1, 2024
Co-authored-by: Ermyas Abebe <[email protected]>
Co-authored-by: Ermyas Abebe <[email protected]>
…ration is just generic onchain
ermyas
approved these changes
Feb 1, 2024
rytimx
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial version of the Random Values Provider. This will provide a standardised interface for games to access random numbers.
The discussion document for the Random Provider is here: https://immutable.atlassian.net/wiki/spaces/BR/pages/2361984032/Secure+Random+Number+Generation+in+the+Immutable+zkEVM
The code is accompanied with description and architecture information and a test plan. The test coverage is 100%.
The PR also updates the solhint configuration in preparation for applying the linting rules across the codebase.
The code in the PR also has had prettier applied to fix basic spacing / formatting issues.
Once the initial version of this code has been merged to main, an entry will be added to developer hub.